Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack doesn't mount provided volume when using creator #674

Closed
simonjjones opened this issue Jun 5, 2020 · 0 comments · Fixed by #675
Closed

Pack doesn't mount provided volume when using creator #674

simonjjones opened this issue Jun 5, 2020 · 0 comments · Fixed by #675
Assignees
Labels
size/sm Small level of effort status/user-accepted Pull Request that has passed user acceptance. type/bug Issue that reports an unexpected behaviour.

Comments

@simonjjones
Copy link
Member

Summary

When building an image using a trusted builder pack now uses a single creator lifecycle phase container to perform all operations. When the --volume argument is passed, this is generally used to instantiate containers for the individual phases that need it. This argument is currently not being respected when initializing a creator phase.


Reproduction

Steps
  1. If we return the acceptance tests for mounting volumes to their original states, expecting the messages to include the file contents some-string the tests will fail
...
---> DETECTING
        ======== Output: volume/bp@volume-bp-version ========
        ---> Detect: Volume Buildpack
        /cnb/buildpacks/volume_bp/volume-bp-version/bin/detect: line 9: /platform/my-volume-mount-target/some-file: No such file or directory
        Detect: Reading file '/platform/my-volume-mount-target/some-file':
        ---> Done
        ...
        ---> BUILDING
        ---> Build: Volume Buildpack
        /cnb/buildpacks/volume_bp/volume-bp-version/bin/build: line 9: /platform/my-volume-mount-target/some-file: No such file or directory
        Build: Reading file '/platform/my-volume-mount-target/some-file':
        ---> Done
...
to contain 'Detect: Reading file '/platform/my-volume-mount-target/some-file': some-string'
...
Current behavior

Creator is not mounted with the expected bind configured with --volume leading a buildpack that expects to find mounted content unable to read it.

Expected behavior

Creator is mounted with the bind configured with --volume, a buildpack can read content from this volume


Environment

Acceptance tests

@simonjjones simonjjones added type/bug Issue that reports an unexpected behaviour. status/triage Issue or PR that requires contributor attention. labels Jun 5, 2020
@simonjjones simonjjones self-assigned this Jun 5, 2020
@simonjjones simonjjones added size/sm Small level of effort status/in-progress Issue or PR that is currently in progress. and removed status/triage Issue or PR that requires contributor attention. labels Jun 5, 2020
simonjjones added a commit that referenced this issue Jun 5, 2020
Resolves #674

Signed-off-by: Simon Jones <[email protected]>
jromero pushed a commit that referenced this issue Jun 8, 2020
@simonjjones simonjjones added status/user-accepted Pull Request that has passed user acceptance. and removed status/in-progress Issue or PR that is currently in progress. labels Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/sm Small level of effort status/user-accepted Pull Request that has passed user acceptance. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant