Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCOW: build produces an unrunnable app image #800

Closed
jromero opened this issue Aug 12, 2020 · 2 comments
Closed

WCOW: build produces an unrunnable app image #800

jromero opened this issue Aug 12, 2020 · 2 comments
Assignees
@micahyoung
Labels
os/windows status/requires-rfc Issue or PR that requires an RFC to be filed.
Milestone
0.14.0

Comments

@jromero
Copy link
Member

jromero commented Aug 12, 2020

Summary

When building a Windows container using the latest version of lifecycle 0.9.0 (which uses platform API 0.4).

Reproduction

Steps
  1. On a WCOW setup run the task make build-windows-apps from https://github.com/buildpacks/samples/pull/85/files
  2. docker run -it --rm sample-batch-script-app:nanoserver-1809
Current behavior
ERROR: failed to launch: cmd execute: exec: "cmd": executable file not found in %PATH%
Expected behavior

Application runs as expected.

Environment

pack info
Pack:
  Version:  0.0.0+git-5e9a21f
  OS/Arch:  windows/amd64

Default Lifecycle Version:  0.9.0

Config:
  experimental=true
docker info
Client:
 Debug Mode: false

Server:
 Containers: 1
  Running: 0
  Paused: 0
  Stopped: 1
 Images: 38
 Server Version: 19.03.12
 Storage Driver: windowsfilter
  Windows:
 Logging Driver: json-file
 Plugins:
  Volume: local
  Network: ics internal l2bridge l2tunnel nat null overlay private transparent
  Log: awslogs etwlogs fluentd gcplogs gelf json-file local logentries splunk syslog
 Swarm: inactive
 Default Isolation: hyperv
 Kernel Version: 10.0 18363 (18362.1.amd64fre.19h1_release.190318-1202)
 Operating System: Windows 10 Pro Version 1909 (OS Build 18363.1016)
 OSType: windows
 Architecture: x86_64
 CPUs: 2
 Total Memory: 7.999GiB
 Name: DESKTOP-D0G2N78
 ID: BKPH:BDOG:5IE3:DKQA:5BYF:D56J:QUHQ:AIUM:NRJR:YYL6:ZWKT:IYNW
 Docker Root Dir: C:\ProgramData\Docker
 Debug Mode: true
  File Descriptors: -1
  Goroutines: 93
  System Time: 2020-08-12T15:03:46.9912819-07:00
  EventsListeners: 1
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: false
 Product License: Community Engine
@jromero jromero added type/bug Issue that reports an unexpected behaviour. status/discussion-needed Issue or PR that requires in-depth discussion. os/windows labels Aug 12, 2020
@jromero jromero added this to the 0.13.0 milestone Aug 12, 2020
@micahyoung micahyoung self-assigned this Aug 13, 2020
micahyoung pushed a commit to micahyoung/buildpacks-samples that referenced this issue Aug 13, 2020
Workaround for pack/issues/800
dbfc2e9 
- Add missing PATH env var to run image so that it gets properly set in app images
- Can be removed once buildpacks/pack#800 is resolved

Signed-off-by: Micah Young <[email protected]>
@micahyoung micahyoung mentioned this issue Aug 13, 2020
Merged
1 task
@jromero jromero self-assigned this Aug 13, 2020
jromero pushed a commit that referenced this issue Aug 13, 2020
@jromero
Fix unrunnable Windows app images due to incomplete PATH env var
3f70cc9 
- Run images need to explicitly set `ENV PATH=C:\\windows...` to workaround differences in convetions for well-known Windows (mcr.microsoft.com/windows/nanoserver:1809) and Linux (alpine/bionic) base images
- Windows base image configs set `Config.Env=null`
- Linux base image configs set `Config.Env=["PATH=/usr/local/bin...",]`

- Works-around #800 though a proper fix in lifecycle will be needed to allow unmodified stacks

Signed-off-by: Micah Young <[email protected]>
@micahyoung micahyoung mentioned this issue Aug 13, 2020
Closed
dwillist pushed a commit to dwillist/pack that referenced this issue Aug 14, 2020
@dwillist
Fix unrunnable Windows app images due to incomplete PATH env var
4163ab9 
- Run images need to explicitly set `ENV PATH=C:\\windows...` to workaround differences in convetions for well-known Windows (mcr.microsoft.com/windows/nanoserver:1809) and Linux (alpine/bionic) base images
- Windows base image configs set `Config.Env=null`
- Linux base image configs set `Config.Env=["PATH=/usr/local/bin...",]`

- Works-around buildpacks#800 though a proper fix in lifecycle will be needed to allow unmodified stacks

Signed-off-by: Micah Young <[email protected]>
@jromero jromero mentioned this issue Aug 17, 2020
Closed
@jromero jromero modified the milestones: 0.13.0, 0.14.0 Aug 19, 2020
micahyoung pushed a commit to micahyoung/buildpacks-samples that referenced this issue Aug 20, 2020
Workaround for pack/issues/800
47cb115 
- Add missing PATH env var to run image so that it gets properly set in app images
- Can be removed once buildpacks/pack#800 is resolved

Signed-off-by: Micah Young <[email protected]>
@jromero jromero removed their assignment Aug 26, 2020
@jromero
Copy link
Member Author

jromero commented Sep 9, 2020

Related: buildpacks/rfcs#114

TLDR; won't fix

@jromero jromero added status/blocked Issue or PR that is blocked. See comments. and removed status/discussion-needed Issue or PR that requires in-depth discussion. labels Sep 9, 2020
@micahyoung
Copy link
Member

The eventual spec change, which would necessitate changes in lifecycle are here: buildpacks/spec#147

@jromero jromero added status/requires-rfc Issue or PR that requires an RFC to be filed. and removed status/blocked Issue or PR that is blocked. See comments. type/bug Issue that reports an unexpected behaviour. labels Sep 23, 2020
@jromero jromero closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micahyoung micahyoung

Labels
os/windows status/requires-rfc Issue or PR that requires an RFC to be filed.
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Limit Windows support to platform API 0.3 buildpacks/pack
2 participants
@micahyoung @jromero