Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default lifecycle values #1067

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Remove default lifecycle values #1067

merged 1 commit into from
Feb 9, 2021

Conversation

dfreilich
Copy link
Member

Signed-off-by: David Freilich [email protected]

Summary

Output

Before

$  pack build test-app -p ~/workspace/samples/apps/bash-script/ -B cnbs/sample-builder:bionic -v
...
===> DETECTING
Running the detector on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/detector -log-level debug -app /workspace -platform /platform
...
===> ANALYZING
Running the analyzer on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/analyzer -log-level debug -daemon -cache-dir /cache -layers /layers test-app
...
===> RESTORING
Running the restorer on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/restorer -log-level debug -cache-dir /cache -layers /layers
...
===> BUILDING
Running the builder on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/builder -log-level debug -layers /layers -app /workspace -platform /platform
...
===> EXPORTING
Running the exporter on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/exporter -daemon -launch-cache /launch-cache -log-level debug -cache-dir /cache -layers /layers -stack /layers/stack.toml -app /workspace -run-image cnbs/sample-stack-run:bionic -process-type web test-app

After

===> DETECTING
Running the detector on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/detector -log-level debug
...
===> ANALYZING
Running the analyzer on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/analyzer -log-level debug -daemon -cache-dir /cache test-app
...
===> RESTORING
Running the restorer on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/restorer -log-level debug -cache-dir /cache
...
===> BUILDING
Running the builder on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/builder -log-level debug
...
===> EXPORTING
Running the exporter on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/exporter -daemon -launch-cache /launch-cache -log-level debug -cache-dir /cache -stack /layers/stack.toml -run-image cnbs/sample-stack-run:bionic -process-type web test-app

Related

Resolves #610

Signed-off-by: David Freilich <[email protected]>
@dfreilich dfreilich requested a review from a team as a code owner February 9, 2021 12:48
@github-actions github-actions bot added this to the 0.18.0 milestone Feb 9, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1067 (9d9b389) into main (af64573) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   80.21%   80.18%   -0.03%     
==========================================
  Files         130      130              
  Lines        7998     7983      -15     
==========================================
- Hits         6415     6400      -15     
  Misses       1163     1163              
  Partials      420      420              
Flag Coverage Δ
os_linux 79.51% <100.00%> (-<0.01%) ⬇️
os_macos 76.87% <100.00%> (-0.04%) ⬇️
os_windows 80.09% <100.00%> (-0.03%) ⬇️
unit 79.56% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero jromero merged commit 24f395c into main Feb 9, 2021
@jromero jromero deleted the 610-lifecycle-default-args branch February 9, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't pass default values explicitly to the lifecycle phases
2 participants