Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a registry pull proxy #1191

Closed
wants to merge 1 commit into from
Closed

Add a registry pull proxy #1191

wants to merge 1 commit into from

Conversation

dwillist
Copy link
Contributor

Signed-off-by: dwillist [email protected]

Summary

Output

Before

All image pulls would come from the registry specified in their name Eg index.docker.io/repo/name:latest would pull from index.docker.io

After

You can specify a pull proxy that re-directs all image pulls. If passed the --pull-proxy index.proxy.io/proxy_registry all image pulls will be routed through this proxy instead of their original.

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@github-actions github-actions bot added this to the 0.19.0 milestone May 24, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label May 24, 2021
@dwillist
Copy link
Contributor Author

dwillist commented Jun 2, 2021

Just to document the state of affairs in the PR.

Whats implemented so far.

The changes needed to be able to pack build with and pass a --pull-proxy flag so that all image pulls go through this proxy.

In general the other pack commands will likely need to have a optional --pull-proxy flag added as well and need to have logic similar to this so that image pulls are forced through the proxy.

Would recommend setting up harbor to test these other commands.

Other commands:

  • inspect image
  • builder create
  • builder inspect
  • buildpack inspect
  • buildpack package
  • rebase

@dfreilich dfreilich modified the milestones: 0.19.0, 0.20.0 Jun 15, 2021
@dfreilich
Copy link
Member

Closing in favor of #1210

@dfreilich dfreilich closed this Jul 4, 2021
@jromero jromero deleted the pull_proxy branch July 21, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants