Support builder description in builder.toml #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Shown in inspect-builder output - Shown in suggested builder output (use default descriptions if not present) [#172] Signed-off-by: Andrew Meyer <[email protected]>
sclevine
previously requested changes
May 9, 2019
| @@ -194,6 +198,10 @@ func hasBPWithVersion(bps []BuildpackMetadata, version string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| func (b *Builder) SetDescription(description string) { | |||
There was a problem hiding this comment.
This is starting to look like Java. Why do we need getters/setters here? I see we're returning a concrete *Builder in the constructor. If we need to change these properties via an interface, could we refactor to pull the state out into data structs?
There was a problem hiding this comment.
@sclevine This type follows a builder-esque pattern (not to be confused with a CNB builder lol) so is stateful. If you still think it should be changed, I'm not sure I'm following your proposed solution. Could you clarify?
There was a problem hiding this comment.
Per side conversation, I'll capture this in a chore and merge as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#172]
Signed-off-by: Andrew Meyer [email protected]