-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .cnb file support for package-buildpack dependencies #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
+ Coverage 70.48% 70.52% +0.04%
==========================================
Files 67 67
Lines 4671 4687 +16
==========================================
+ Hits 3292 3305 +13
- Misses 1061 1063 +2
- Partials 318 319 +1
|
dfreilich
force-pushed
the
586-support-cnb-files-package-buildpack
branch
from
May 18, 2020 19:19
37a31da
to
204a046
Compare
jromero
suggested changes
May 19, 2020
dfreilich
force-pushed
the
586-support-cnb-files-package-buildpack
branch
from
May 19, 2020 14:20
204a046
to
cc62616
Compare
jromero
suggested changes
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks in testing.
* Close #586 Signed-off-by: David Freilich <[email protected]>
Signed-off-by: David Freilich <[email protected]>
Signed-off-by: David Freilich <[email protected]>
…removing it in After Signed-off-by: David Freilich <[email protected]>
dfreilich
force-pushed
the
586-support-cnb-files-package-buildpack
branch
2 times, most recently
from
May 19, 2020 20:38
3f4d22f
to
ed7971f
Compare
* Remove extraneous assertions when asserting about PackageBPFile Signed-off-by: David Freilich <[email protected]>
dfreilich
force-pushed
the
586-support-cnb-files-package-buildpack
branch
from
May 19, 2020 21:26
776a625
to
44a9f8c
Compare
✔️ Accepted
|
jromero
approved these changes
May 20, 2020
jromero
added
the
type/enhancement
Issue that requests a new feature or improvement.
label
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Freilich [email protected]