Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google builder to suggested builders #637

Merged
merged 6 commits into from
May 20, 2020
Merged

Conversation

jromero
Copy link
Member

@jromero jromero commented May 19, 2020

Also:

  • Clean up acceptance logging
  • Sort builders by vendor instead of image name

Resolves #635

Output

$ ./out/pack suggest-builders

Suggested builders:
        Google:                gcr.io/buildpacks/builder                    GCP Builder for all runtimes                                                                   
        Heroku:                heroku/buildpacks:18                         heroku-18 base image with buildpacks for Ruby, Java, Node.js, Python, Golang, & PHP            
        Paketo Buildpacks:     gcr.io/paketo-buildpacks/builder:base        Ubuntu bionic base image with buildpacks for Java, NodeJS and Golang                           
        Paketo Buildpacks:     gcr.io/paketo-buildpacks/builder:full-cf     cflinuxfs3 base image with buildpacks for Java, .NET, NodeJS, Golang, PHP, HTTPD and NGINX     
        Paketo Buildpacks:     gcr.io/paketo-buildpacks/builder:tiny        Tiny base image (bionic build image, distroless run image) with buildpacks for Golang          

Tip: Learn more about a specific builder with:
        pack inspect-builder <builder-image>

@jromero jromero requested a review from a team as a code owner May 19, 2020 14:56
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #637 into master will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   70.42%   70.25%   -0.17%     
==========================================
  Files          67       67              
  Lines        4665     4671       +6     
==========================================
- Hits         3285     3281       -4     
- Misses       1062     1072      +10     
  Partials      318      318              
Flag Coverage Δ
#os_linux 72.88% <100.00%> (-0.22%) ⬇️
#os_macos 68.86% <100.00%> (-0.22%) ⬇️
#os_windows 68.79% <100.00%> (-0.17%) ⬇️
#unit 70.25% <100.00%> (-0.17%) ⬇️

@jromero
Copy link
Member Author

jromero commented May 19, 2020

@lukasberger / @dgageot please let us know if this is not something you'd prefer.

@jromero jromero merged commit 896eb4e into master May 20, 2020
@jromero jromero deleted the feature/635-google-builder branch May 20, 2020 00:04
@jromero jromero added this to the 0.11.0 milestone May 20, 2020
@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add google builder to suggested builders
1 participant