Remove /lifecycle symlink on created builders
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 73.52% 73.53% +0.02%
==========================================
Files 75 75
Lines 5112 5103 -9
==========================================
- Hits 3758 3752 -6
+ Misses 1039 1037 -2
+ Partials 315 314 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
- reduces flakes that result from gouroutines sharing environment variables Signed-off-by: dwillist <[email protected]>
Signed-off-by: dwillist <[email protected]>
Signed-off-by: dwillist <[email protected]>
dwillist
force-pushed
the
460-remove-symlink
branch
from
0d82f12 to
5b67313
Compare
| @@ -18,7 +18,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestSetRunImageMirrorsCommand(t *testing.T) { | |||
| spec.Run(t, "Commands", testSetRunImageMirrorsCommand, spec.Parallel(), spec.Report(report.Terminal{})) | |||
| spec.Run(t, "Commands", testSetRunImageMirrorsCommand, spec.Sequential(), spec.Report(report.Terminal{})) | |||
There was a problem hiding this comment.
I'm sort of confused by this as it seems we use spec.Parallel() more often than spec.Sequential(). What's the reason that this test needs to be run sequentially?
There was a problem hiding this comment.
This test is uses environment variables during setup here and here, environment variables are shared by goroutines so running this test with any sort of parallelism will have race conditions. Using make unit runs unit tests sequentially by using a single goroutine configured here so they end up passing.
jromero
added
breaking-change
jromero
approved these changes
Jul 27, 2020
jromero
changed the title
/lifecycle symlink on created builders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove code to create obsolete
/lifecyclesymlink in buildersSmall fix to run image mirror tests to disable parallel test execution.
Before
Directory structure of builders:
After
Directory structure of builders:
Documentation
No documentation needed
Related
Resolves #460