-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement add-buildpack-registry
#847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbandito
force-pushed
the
add_registry
branch
from
September 23, 2020 16:19
d291ae1
to
0e45d68
Compare
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 76.14% 76.29% +0.16%
==========================================
Files 84 86 +2
Lines 4370 4407 +37
==========================================
+ Hits 3327 3362 +35
- Misses 699 700 +1
- Partials 344 345 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
elbandito
force-pushed
the
add_registry
branch
3 times, most recently
from
September 23, 2020 16:45
91233b6
to
5925aff
Compare
Signed-off-by: Travis <[email protected]>
elbandito
force-pushed
the
add_registry
branch
from
September 23, 2020 17:05
5925aff
to
917bc11
Compare
elbandito
changed the title
feat: add buildpack registry configuration
feat: add buildpack registry
Sep 23, 2020
Signed-off-by: Javier Romero <[email protected]>
Signed-off-by: Javier Romero <[email protected]>
Signed-off-by: Javier Romero <[email protected]>
jromero
approved these changes
Sep 23, 2020
jromero
added
experimental
Issue or PR refers to an experimental feature.
type/enhancement
Issue that requests a new feature or improvement.
labels
Sep 23, 2020
This was referenced Sep 24, 2020
jromero
changed the title
feat: add buildpack registry
Implement Sep 28, 2020
add-buildpack-registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
experimental
Issue or PR refers to an experimental feature.
type/enhancement
Issue that requests a new feature or improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (WIP)
This is a new command that allows users to add new buildpack registries to their
config.toml
file. The user also has the option via--default
flag to set the newly added registry as the new default registry.Output
Documentation
Related
Resolves #___