Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add-buildpack-registry #847

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Implement add-buildpack-registry #847

merged 6 commits into from
Sep 23, 2020

Conversation

elbandito
Copy link
Member

@elbandito elbandito commented Sep 23, 2020

Summary (WIP)

This is a new command that allows users to add new buildpack registries to their config.toml file. The user also has the option via --default flag to set the newly added registry as the new default registry.

Output

➜  pack add-buildpack-registry --help                                          
Adds a new buildpack registry to your pack config file

Usage:
  pack add-buildpack-registry <name> <url> <type> (github | git) [flags]

Examples:
pack add-buildpack-registry myregistry github https://github.com/buildpacks/mybuildpack

Flags:
      --default   Set this buildpack registry as the default
  -h, --help      Help for 'add-registry'

Global Flags:
      --no-color     Disable color output
  -q, --quiet        Show less output
      --timestamps   Enable timestamps in output
  -v, --verbose      Show more output
➜ pack add-buildpack-registry buildpack https://github.com/buildpacks/registry github
Successfully added buildpack to buildpack registries
➜ pack add-buildpack-registry buildpack https://github.com/buildpacks/registry github
ERROR: add buildpack registry: Buildpack registry buildpack already exists.  First run remove-buildpack-registry buildpack and try again.

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #847 into main will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
+ Coverage   76.14%   76.29%   +0.16%     
==========================================
  Files          84       86       +2     
  Lines        4370     4407      +37     
==========================================
+ Hits         3327     3362      +35     
- Misses        699      700       +1     
- Partials      344      345       +1     
Flag Coverage Δ
#os_linux 76.29% <ø> (+0.16%) ⬆️
#os_macos 72.87% <ø> (+0.19%) ⬆️
#os_windows 100.00% <ø> (ø)
#unit 76.29% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elbandito elbandito force-pushed the add_registry branch 3 times, most recently from 91233b6 to 5925aff Compare September 23, 2020 16:45
@elbandito elbandito changed the title feat: add buildpack registry configuration feat: add buildpack registry Sep 23, 2020
@jromero jromero self-assigned this Sep 23, 2020
@jromero
Copy link
Member

jromero commented Sep 23, 2020

Accepted

Some screenshots of the manual tests.

image

image

image

image

image

image

@jromero jromero marked this pull request as ready for review September 23, 2020 22:19
@jromero jromero requested a review from a team as a code owner September 23, 2020 22:19
@jromero jromero added this to the 0.14.0 milestone Sep 23, 2020
@jromero jromero added experimental Issue or PR refers to an experimental feature. type/enhancement Issue that requests a new feature or improvement. labels Sep 23, 2020
@jromero jromero merged commit 0a1b631 into main Sep 23, 2020
@jromero jromero deleted the add_registry branch September 23, 2020 22:20
@jromero jromero changed the title feat: add buildpack registry Implement add-buildpack-registry Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Issue or PR refers to an experimental feature. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants