Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generic error definition to base.json. #5

Merged
merged 3 commits into from
Apr 23, 2018
Merged

Added generic error definition to base.json. #5

merged 3 commits into from
Apr 23, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Apr 23, 2018

No description provided.

@OGKevin OGKevin self-assigned this Apr 23, 2018
@OGKevin OGKevin requested a review from sandervdo April 23, 2018 14:57
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 23, 2018

@sandervdo please 👀

sandervdo
sandervdo approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@sandervdo sandervdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 23, 2018

👌

@OGKevin OGKevin merged commit 4a31a81 into develop Apr 23, 2018
@OGKevin OGKevin deleted the add_4xx_response branch April 23, 2018 15:12
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 23, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandervdo sandervdo sandervdo approved these changes

Assignees

@OGKevin OGKevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OGKevin @sandervdo