Implemented sidebar (bunq/doc#75) #77
Conversation
src/plugins/BunqLayoutPlugin/components/SidebarItem/SidebarItem.js
Outdated
Show resolved
Hide resolved
src/plugins/BunqLayoutPlugin/components/SidebarItem/SidebarItem.js
Outdated
Show resolved
Hide resolved
src/plugins/BunqLayoutPlugin/components/SidebarItem/SidebarItem.js
Outdated
Show resolved
Hide resolved
|
@melikesofta please check again |
| /** | ||
| * @returns {Node} | ||
| */ | ||
| renderSidebar (): Node { |
There was a problem hiding this comment.
I prefer to always have the original render() at the bottom of the file because I automatically look at the bottom when I'm looking for it. but your choice I guess, as long as you keep it consistent in the future
parrello
changed the title
| } | ||
|
|
||
| window.setTimeout(() => { | ||
| const scrollContainer = document.querySelector(".swagger-ui"); |
There was a problem hiding this comment.
I think this is fine for this one usecase, but for later you might wanna checkout refs in react and how dom is manipulated, to better stay in the react paradigm and to not directly touch the real dom etc https://reactjs.org/docs/refs-and-the-dom.html#refs-and-finddomnode
There was a problem hiding this comment.
in this case I went for this implementation because it matches the way Swagger does it, but you are right
|
@parrello left a few small comments, but good to go from my side! |
No description provided.