Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monetary account joint retrieval bunq/sdk_java#45 #91

Merged
merged 10 commits into from
Jun 1, 2018
Merged

Fix monetary account joint retrieval bunq/sdk_java#45 #91

merged 10 commits into from
Jun 1, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented May 29, 2018

References #45

@OGKevin OGKevin added this to the 0.13.5 milestone May 29, 2018
@OGKevin OGKevin self-assigned this May 29, 2018
@bunq bunq deleted a comment May 29, 2018
@bunq bunq deleted a comment May 29, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented May 29, 2018

@patrickdw1991 all yours, please 👀

@OGKevin OGKevin requested a review from patrickdw1991 May 29, 2018 14:18
patrickdw1991
patrickdw1991 requested changes May 29, 2018
View reviewed changes
src/main/java/com/bunq/sdk/model/generated/endpoint/AttachmentConversationContent.java Outdated
@@ -33,7 +33,6 @@

return new BunqResponse<>(responseRaw.getBodyBytes(), responseRaw.getHeaders());
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? :'(

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all generated files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, lets see.

@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 1, 2018

@patrickdw1991 regenerated.

@OGKevin OGKevin merged commit ad655b1 into develop Jun 1, 2018
@OGKevin OGKevin deleted the fix_monetary_account_joint_retrieval_bunq/sdk_java#45 branch June 1, 2018 12:38
@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 1, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdw1991 patrickdw1991 patrickdw1991 approved these changes

Assignees

@OGKevin OGKevin

Labels
Can be merged Travis CI passed
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@OGKevin @patrickdw1991