-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing type hints #1321
Comments
Looking into this. Most of the type errors come from one place. In Dimension = namedtuple("Dimension", ["rows", "cols"])("ROWS", "COLUMNS") It seems like a better solution for this is a |
Hi! Thanks for looking into it! One thing I forgot to mention in the issue: this work should be done on the 6.0.0 release branch. On this branch, as you suggested, we have already switched to StrEnums. Also, see the linked PR #1337. I (think that I) fixed the remaining type issues there, and the work is complete. If you are still interested, do have a look. Some things may be patched over with |
Well drats. I've already made all the necessary changes and was about to open a PR. Serves me right for skimming this issue. |
Replaces singleton named tuples in utils.py with StrEnums. Adds the qualified dependency for str enum to pyproject.toml for python versions below 3.11. Fixes one or two other minor type issues. Signed-off-by: Ben Shaver <[email protected]>
Consider #1340 a suggestion. That way you only install |
closed by #1337
My bad for not including the branch in the issue description. I should have done this, especially as I tagged this as |
This work should be done in the 6.0.0 release branch
Run
mypy --install-types --non-interactive --ignore-missing-imports ./gspread
(from CI) to see which types are broken/missingThe text was updated successfully, but these errors were encountered: