-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove StrEnum dependency #1462
Comments
Hi that's true, it's simple enough to be vendored (meaning we copy/paste the current code in our repository) the pros & cons: pros:
cons:
I have no strong preference 🙄 do we have a major/manior reason to do this move ? is this blocking some users or something ? |
I think this is something that will not change very often. We basically just use it to polyfill old Python versions, and do not use any advanced features of StrEnum gspread is usable before without installing StrEnum and I think this is nicer. |
Wouldn't this need to be conditional then? |
Context: I think there are many "solutions" to this issue, and they all depend on what "problem" we are trying to solve. Personally, I think the dependency is not needed, especially as we have so few dependencies to begin with (apart from the required Google Auth, we have none (or, only StrEnum, which I argue is unneeded)) |
Yeah I just checked the I can add it, if y'all would like. |
That would be grand 😊 I think there are many ways to add this. One would be to provide this StrEnum class/subclass in the Would you like any guidance? I trust you can make a good change :) |
Remove StrEnum dependency and added custom class[issue #1462]
gspread dependencies are:
gspread/pyproject.toml
Lines 30 to 34 in c740b88
StrEnum amounts to
We ought not need to rely on a dependency, and can think of a way of including this code in the project, so that the dependencies are just google auth libraries.
@lavigne958 thoughts?
The text was updated successfully, but these errors were encountered: