Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the friendly unauthorized message, based on Frankenstein's suggestions #1554

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

srabraham
Copy link
Member

@srabraham srabraham commented Jan 22, 2025

This is pretty much the same as Frankenstein's suggestion in the following issue, with a few minor tweaks.

#1528

@srabraham srabraham requested a review from mikeburg January 22, 2025 20:59
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (0f88a3c) to head (048585c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/application/_klein.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
- Coverage   69.91%   69.87%   -0.05%     
==========================================
  Files         186      186              
  Lines        9218     9221       +3     
  Branches     1485     1486       +1     
==========================================
- Hits         6445     6443       -2     
- Misses       2661     2665       +4     
- Partials      112      113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chaoticbear chaoticbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srabraham srabraham merged commit ecfdde1 into master Jan 23, 2025
12 of 13 checks passed
@srabraham srabraham deleted the 2025-01-20-no-legal-names branch January 23, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants