Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove keplr related deps #254

Merged
merged 2 commits into from
Jan 7, 2025
Merged

remove keplr related deps #254

merged 2 commits into from
Jan 7, 2025

Conversation

BurntVal
Copy link
Contributor

@BurntVal BurntVal commented Jan 6, 2025

After an issue with the github release workflow, we found an issue with a nested 3-party dependency, stemming from our use of the keplr packages.

This PR aims to remove any dependency on the keplr packages:

  1. To resolve the release workflow bug
  2. To reduce number of 3rd party deps utilized

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: e463feb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@burnt-labs/abstraxion-core Minor
demo-app Minor
@burnt-labs/abstraxion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xion-js-demo-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 8:31pm

Copy link
Contributor

@justinbarry justinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BurntNerve BurntNerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2!

@justinbarry justinbarry merged commit ad2160d into main Jan 7, 2025
3 checks passed
@justinbarry justinbarry deleted the fix/keplr-dep-bug branch January 7, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants