-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation Violation in appendListedPackages #694
Comments
We're probably not able to do much here if we don't have a way to reproduce the issue. |
mvdan
added a commit
to mvdan/garble-fork
that referenced
this issue
Mar 10, 2023
I mistakenly understood that, when the DepsErrors field has errors, the Error field would contain an error as well. That is not always the case; for example, the imports_missing package in the added test script had DepsErrors set but Error empty, causing a nil dereference panic. Make the code more robust, and report both kinds of load errors. Fixes burrowers#694.
mvdan
added a commit
to mvdan/garble-fork
that referenced
this issue
Mar 10, 2023
I mistakenly understood that, when the DepsErrors field has errors, the Error field would contain an error as well. That is not always the case; for example, the imports_missing package in the added test script had DepsErrors set but Error empty, causing a nil dereference panic. Make the code more robust, and report both kinds of load errors. Fixes burrowers#694.
mvdan
added a commit
that referenced
this issue
Mar 11, 2023
I mistakenly understood that, when the DepsErrors field has errors, the Error field would contain an error as well. That is not always the case; for example, the imports_missing package in the added test script had DepsErrors set but Error empty, causing a nil dereference panic. Make the code more robust, and report both kinds of load errors. Fixes #694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Garble and Go are you using?
What environment are you running Garble on?
go env
OutputWhat did you do?
Ran garble build using GoReleaser. Build line is the following:
I'm really not sure how to reproduce this issue as it seems to only happen in my CI environment.
What did you expect to see?
No errors and a clean build
What did you see instead?
Any help would be appreciated
The text was updated successfully, but these errors were encountered: