Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward-delete in list items #124

Merged
merged 3 commits into from
Sep 14, 2015
Merged

forward-delete in list items #124

merged 3 commits into from
Sep 14, 2015

Conversation

bantic
Copy link
Collaborator

@bantic bantic commented Sep 10, 2015

This fixes #118

Adds test cases for:

  • forward-delete when at end of a (non-empty) list item and:
    • there is no markerable section immediately following it (i.e., end of document or card section following)
    • there is a list item following it
    • there is a markup section following it
  • forward-delete when cursor is in empty list item and:
    • there is no markerable section immediately following it
    • there is a list item following it
    • there is a markup section following it

@bantic bantic force-pushed the forward-delete-list-item-118 branch from e5bc917 to 65e4c37 Compare September 10, 2015 15:45
@bantic bantic changed the title *do not merge* forward-delete in list items Sep 10, 2015
@bantic bantic force-pushed the forward-delete-list-item-118 branch 2 times, most recently from a01d54f to b2fca7e Compare September 10, 2015 16:11
@bantic bantic force-pushed the forward-delete-list-item-118 branch 2 times, most recently from 1b882fa to a5dfddc Compare September 14, 2015 15:12
@bantic bantic force-pushed the forward-delete-list-item-118 branch from a5dfddc to a8e19da Compare September 14, 2015 15:16
bantic added a commit that referenced this pull request Sep 14, 2015
@bantic bantic merged commit 501ec53 into master Sep 14, 2015
@bantic bantic deleted the forward-delete-list-item-118 branch September 14, 2015 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forward-delete in empty list item causes js error
1 participant