Implement card refactor for editor-dom renderer #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let { card: { name } } = this; | ||
| assert( | ||
| `Card "${name}" must render dom (render value was: "${rendered}")`, | ||
| (typeof rendered === 'object') |
There was a problem hiding this comment.
perhaps rendered.nodeType is a good check for rendered being a node.
|
seems good. |
bantic
added a commit
that referenced
this pull request
Nov 19, 2015
This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 This allows rendering, but the cards themselves don't render yet because ember-mobiledoc-editor doesn't use the updates to mobiledoc-kit from #238 wip refs #236
bantic
force-pushed
the
update-editor-dom-card-renderer-236
branch
4 times, most recently
from
f63a2a7 to
fb2fa36
Compare
Update cards to be in format expected by dom renderer This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 Reorganize demo cards into dom/ html/ and text/ directories fixes #236 fixes #239 Update html and text renderer dependencies
bantic
force-pushed
the
update-editor-dom-card-renderer-236
branch
from
ba6eb61 to
3baafbe
Compare
bantic
added a commit
that referenced
this pull request
Nov 23, 2015
…er-236 Implement card refactor for editor-dom renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback welcome. Merging this needs to be coordinated with changes to other codebases as described in #235
checklist:
unknownCardHandlerusage/defaults for editorfixes #236