-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug #326: Cross-browser testing on CI #337
Conversation
@YoranBrondsema Thank you! Can we travis-encrypt the sauce account/username for CI? I'll review this locally soon, hopefully tonight. |
If that's viable, I will encrypt and add the official mobiledoc-kit sauce labs credentials into the .travis.yml |
That should be possible in theory, although I don't know if it's directly supported by |
@YoranBrondsema this looks great. Is it possible to configure the sauce connection through travis/testem such that it shows the phantom results inline but groups the per-browser results as a single result, the way they do in glimmer's CI? Scroll down to the end where you'll see lines like:
|
Sure thing, done. Some other things:
|
@YoranBrondsema This is great. Just two more things: |
@bantic Cool no worries. I restored PhantomJS, added Edge and squashed the commits. Let me know if there's something I forgot! |
awesome! Thank you |
Fix bug #326: Cross-browser testing on CI
Integrate Sauce Labs into CI to test on different browsers.
Browsers
Chrome
Latest version, currently 48.
Firefox
Latest version, currently 44.
IE11
Had to disable some tests in order to pass the suite (added TODOs). I further had problems with all copy-pasting tests as the browser requires to manually allow setting data in the clipboard. A way has to be found to do this automatically (see https://answers.microsoft.com/en-us/ie/forum/ie11-iewindows8_1/clipboard-access-in-ie-11/94ab3483-828a-4e55-974a-cb4cc98e94c7).
Edge
Latest version.
Safari 9 (enabled)
All good.
Comments
SAUCE_USERNAME
andSAUCE_ACCESS_KEY
environment variables.Other changes
testem
to 1.4.0