Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #326: Cross-browser testing on CI #337

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Fix bug #326: Cross-browser testing on CI #337

merged 1 commit into from
Mar 2, 2016

Conversation

YoranBrondsema
Copy link
Collaborator

Integrate Sauce Labs into CI to test on different browsers.

Browsers

Chrome

Latest version, currently 48.

Firefox

Latest version, currently 44.

IE11

Had to disable some tests in order to pass the suite (added TODOs). I further had problems with all copy-pasting tests as the browser requires to manually allow setting data in the clipboard. A way has to be found to do this automatically (see https://answers.microsoft.com/en-us/ie/forum/ie11-iewindows8_1/clipboard-access-in-ie-11/94ab3483-828a-4e55-974a-cb4cc98e94c7).

Edge

Latest version.

Safari 9 (enabled)

All good.

Comments

  • @bantic You had only given me the Sauce Labs access code but the username of the account is also required. In order to ease setting up, I created an account myself. Obviously, this will have to be replaced with you account.
  • Also, I don't know what the best way is to store the SAUCE_USERNAME and SAUCE_ACCESS_KEY environment variables.

Other changes

  • Update testem to 1.4.0

@bantic
Copy link
Collaborator

bantic commented Feb 23, 2016

@YoranBrondsema Thank you! Can we travis-encrypt the sauce account/username for CI? I'll review this locally soon, hopefully tonight.

@bantic
Copy link
Collaborator

bantic commented Feb 23, 2016

Can we travis-encrypt the sauce account/username for CI

If that's viable, I will encrypt and add the official mobiledoc-kit sauce labs credentials into the .travis.yml

@YoranBrondsema
Copy link
Collaborator Author

If that's viable, I will encrypt and add the official mobiledoc-kit sauce labs credentials into the .travis.yml

That should be possible in theory, although I don't know if it's directly supported by saucie (https://github.com/johanneswuerbach/saucie). However, in any case it should be done I think!

@bantic
Copy link
Collaborator

bantic commented Feb 24, 2016

@YoranBrondsema this looks great. Is it possible to configure the sauce connection through travis/testem such that it shows the phantom results inline but groups the per-browser results as a single result, the way they do in glimmer's CI? Scroll down to the end where you'll see lines like:

ok 390 SL_Chrome_Current - https://saucelabs.com/jobs/97125e2afb4748468a050485c2f0c4ef
ok 391 SL_Chrome_Last - https://saucelabs.com/jobs/70393bd1aee44116b0631b1c6b841330
ok 392 SL_Firefox_Current - https://saucelabs.com/jobs/d2e4de2ecbc24d60a3727e33aa28d97a`

@YoranBrondsema
Copy link
Collaborator Author

Is it possible to configure the sauce connection through travis/testem such that it shows the phantom results inline but groups the per-browser results as a single result, the way they do in glimmer's CI?

Sure thing, done.

Some other things:

@bantic
Copy link
Collaborator

bantic commented Mar 1, 2016

@YoranBrondsema This is great. Just two more things:
Can we restore the phantomjs output (in full — individual lines per test) and then would you mind squashing the commits? This looks great, I am very pleased to have these tests going.

@YoranBrondsema
Copy link
Collaborator Author

@bantic Cool no worries. I restored PhantomJS, added Edge and squashed the commits. Let me know if there's something I forgot!

@bantic
Copy link
Collaborator

bantic commented Mar 2, 2016

awesome! Thank you

bantic added a commit that referenced this pull request Mar 2, 2016
@bantic bantic merged commit 437623e into bustle:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants