Handle newline at start or end of section #53
Conversation
bantic
force-pushed
the
newline-at-section-start
branch
from
1c61002 to
db8690f
Compare
| } else { | ||
| // start of section, remove the existing marker and add a blank one | ||
| section.markers.remove(marker); | ||
| section.markers.append(this.builder.createBlankMarker()); |
There was a problem hiding this comment.
Not needed, but alternatively:
section.markers.splice(marker, 1, [this.builder.createBlankMarker()]);
There was a problem hiding this comment.
Oh I'm sorry, I misread this. You're removing a marker from some arbitrary place and only appending the blank marker, all the time.
There was a problem hiding this comment.
I'm confused- shouldn't the blank marker be in a new section?
There was a problem hiding this comment.
Yeah, agreed, this is fairly confusing. I'm reworking this to be a bit more declarative.
|
hold off on merging for the moment. I'm reworking |
* simplify section#splitMarker * tests for hitting enter in middle and end of section * add test for hitting enter in first section * fix bug with PostNodeBuilder not assigning a builder to the blank marker fixes #39
bantic
force-pushed
the
newline-at-section-start
branch
from
db8690f to
3f113b3
Compare
|
@mixonic this is ready now if you want to look it over |
| */ | ||
| coalesceMarkers() { | ||
| forEach( | ||
| filter(this.markers, m => m.empty()), |
There was a problem hiding this comment.
m.empty should probably be m.isEmpty
Also doing a filter only to pass it to another iterator seems wasteful- this could be done in a single pass with an if
There was a problem hiding this comment.
changed the loop on master, we can ponder empty
There was a problem hiding this comment.
@mixonic removing markers while iterating them causes the iteration to skip (item.next is something different before/after the callback). I have a PR coming to fix iteration of the linkedlist
Handle newline at start or end of section
Handle newline at start of section
fixes #39