Close markers properly in editor-dom renderer #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to a more naive rendering strategy:
* find the number of markups this marker has in common with its prev/next
marker, slice off that number from its own markups and return that
as the opened/closed markups.
* This allows us to simply walk up the number of closed markups again.
* The drawback is that this will cause some unnecessary open/closed markups
(closing one only to immediately reopen it in the following marker, e.g.)
mixonic
added a commit
that referenced
this pull request
Aug 11, 2015
Close markers properly in editor-dom renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a more naive rendering strategy:
marker, slice off that number from its own markups and return that
as the opened/closed markups.
(closing one only to immediately reopen it in the following marker, e.g.)
fixes #63