Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed atoms with no text value being removed when parsing top-level markerables #679

Merged
merged 1 commit into from
May 7, 2019
Merged

🐛 Fixed atoms with no text value being removed when parsing top-level markerables #679

merged 1 commit into from
May 7, 2019

Conversation

kevinansfield
Copy link
Collaborator

no issue

  • the "empty section" skips in the section and dom parsers were a little too over-zealous and were skipping over no-text atoms such as a soft-breaks that were created by parser plugins

@kevinansfield
🐛 Fixed atoms with no text value being removed when parsing top-level…
4828dd6 
… markerables

no issue

- the "empty section" skips in the section and dom parsers were a little too over-zealous and were skipping over no-text atoms such as a soft-breaks that were created by parser plugins
@kevinansfield kevinansfield requested a review from mixonic May 3, 2019 16:32
mixonic
mixonic approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Good catch @kevinansfield

@mixonic mixonic merged commit 9e5f064 into bustle:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic mixonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinansfield @mixonic