Fix clicking when there is no active cursor. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors the `offsets` return value into a `Range` object consisting of two `Position` objects. These encapsulate the difficulties of creating a meaningful position data-set for a given DOM node.
|
Also moved |
|
|
||
| if (!range) { | ||
| if (selection.rangeCount === 0 || !selection.getRangeAt(0)) { |
There was a problem hiding this comment.
I think selection.rangeCount === 0 is sufficient. I'm not sure what circumstance would result in the rangeCount being non-zero and getRangeAt(0) returning undefined
|
👍 |
bantic
added a commit
that referenced
this pull request
Aug 26, 2015
Fix clicking when there is no active cursor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors the
offsetsreturn value into aRangeobject consisting of twoPositionobjects. These encapsulate the difficulties of creating a meaningful position data-set for a given DOM node.