Implement Lists #94
Implement Lists #94
Conversation
bantic
force-pushed
the
lists-2
branch
9 times, most recently
from
08a1487 to
0ccf488
Compare
|
@mixonic Could use review. This is ready to go now. After review I can update the standalone renderers to handle lists |
bantic
force-pushed
the
lists-2
branch
2 times, most recently
from
61c9e08 to
9ce308c
Compare
| QUnit.config.urlConfig.push({ | ||
| id: 'debugTest', | ||
| label: 'Debug Test' | ||
| }); |
There was a problem hiding this comment.
this is a little odd, perhaps, but it greatly improves debugging speed for acceptance tests. This adds a checkbox 'DebugTest' in the QUnit toolbar. Clicking it causes the page to reload and drop into the debugger right before starting the test. The flow I've been using is:
- run all tests (with dev tools open), click "rerun test" on any failing acceptance test
- click the "Debug Test" checkbox -> page reloads and the debugger activates
- step into the
originalCallbacktest function and step through the lines in the test
I've found this to be a lot quicker than finding the test code in my text editor and reading through the steps to figure out what it is testing and what should be happening.
The caveat is that you need to import {test, module} from Helpers in the acceptance test (instead of import {test, module} from QUnit)
There was a problem hiding this comment.
👍 seems cool, eager to give it a try
| @@ -104,6 +111,37 @@ function renderMarker(marker, element, previousRenderNode) { | |||
| return textNode; | |||
| } | |||
|
|
|||
| function attachRenderNodeElementToDOM(renderNode, element, originalElement) { | |||
if it is good enough for Alex, it's good for me: http://www.2ality.com/2015/08/object-literals-es5.html#trailing_commas_are_legal
* simplify editor reparse * update post parser to reparse list sections * hit enter to split a list item * can delete to exit a list * hitting enter in empty list item exits list section altogether * Use Helpers.dom.build rather than `makeDOM` * Test to ensure that hitting enter in a list exits the list appropriately
|
sweeeeeeeeetttttt |
ready to merge
fixes #86
This adds a:
ListSection— inherits fromMarkupSectionand lives alongsideMarkupSections and cards in the post'ssectionslistListItem— inherits fromMarkupSectionand lives in the nesteditems/sectionslist on aListSection, has a list ofmarkerspostEditor#splitSectionto deal with hitting enter on an empty final list itemListItem#splitAtMarkerthat could be cleaned upeditor#reparseby recognizing that there are fewer unexpected situations that could occurStil to do: