Introduce lifecycle hooks #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bantic this is good to go. |
Closed
| @@ -319,6 +332,8 @@ class Editor { | |||
| showForTag: 'a' | |||
| })); | |||
|
|
|||
| // Stub out a post editing session for initial render | |||
| this.run(() => {}); | |||
There was a problem hiding this comment.
Why is the empty run there? It's not clear to me from that comment.
There was a problem hiding this comment.
Will elaborate, poor wording there.
* didUpdatePost, which gets passed the postEditor * willRender, before render after post changes are complete * didRender, after render when DOM and post are in sync
|
🎉 |
| @@ -319,6 +332,9 @@ class Editor { | |||
| showForTag: 'a' | |||
| })); | |||
|
|
|||
| // A call to `run` will trigger the didUpdatePostCallbacks hooks with a | |||
| // postEditor. | |||
| this.run(() => {}); | |||
There was a problem hiding this comment.
Maybe this should be this.runCallbacks() or something? This looks like the sort of no-op-y code that will get deleted by someone in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: