Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shows with no seasons, single episode #120

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

simark
Copy link
Collaborator

@simark simark commented Nov 13, 2017

Some shows (https://ici.tou.tv/arthur-laventurier-au-costa-rica, at the
time of writing) have a single episode, and their SeasonLineups
attribute is None. We can still download them if we treat the top-level
object as the episode (the important value is idMedia, which we will
eventually use to get the playlist of video segments). This patch
attempts to do this.

Some shows (https://ici.tou.tv/arthur-laventurier-au-costa-rica, at the
time of writing) have a single episode, and their SeasonLineups
attribute is None.  We can still download them if we treat the top-level
object as the episode (the important value is idMedia, which we will
eventually use to get the playlist of video segments).  This patch
attempts to do this.
@simark simark requested a review from gboudreau November 13, 2017 04:59
Copy link
Contributor

@gboudreau gboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually test it, but I reviewed the code change, and it looks good to me.

@simark simark merged commit a16b99b into bvanheu:master Nov 13, 2017
@simark
Copy link
Collaborator Author

simark commented Nov 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants