Feature/extra - Let the user login & fetch an episode in 720p #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvanheu
changed the title
| r = requests.get(url, params=params, headers=toutv.config.HEADERS, | ||
| headers = dict(toutv.config.HEADERS) | ||
|
|
||
| if auth and params: |
There was a problem hiding this comment.
why "auth and param"?
What happens if no params are passed, but we still want to authenticate?
There was a problem hiding this comment.
The only case where we don't have any params is when we download the segments from the Akamai server. I just wanted to avoid an uncessary HTTP request to get a claims.
|
Quick note: |
|
This PR is now deprecated; this functionality was merged into master a while ago. See #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sup guys,
I've implemented a basic auth module to let people fetch the HD content from the extra section.
I didn't find a way to fetch the extra content, but at least one can download any supported episode in 720p so I thought we could at least push this into the repository.
I have extended the CLI with the 'login' command. You can try it by running:
Then:
Review & comment please!