Merge pull request facebook#118 from gaearon/required-title

Add missing Button titles
bvaughn · Apr 10, 2019 · ba46f2d · ba46f2d
2 parents 98240f1 + 75a4312
commit ba46f2d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/src/devtools/views/Button.js b/src/devtools/views/Button.js
@@ -6,6 +6,7 @@ import styles from './Button.css';
 
 type Props = {
   className?: string,
+  title: string,
 };
 
 export default function Button({ className, ...rest }: Props) {

diff --git a/src/devtools/views/Components/HooksTree.js b/src/devtools/views/Components/HooksTree.js
@@ -31,7 +31,7 @@ export function HooksTreeView({ canEditHooks, hooks, id }: HooksTreeViewProps) {
       <div className={styles.HooksTreeView}>
         <div className={styles.HeaderRow}>
           <div className={styles.Header}>hooks</div>
-          <Button onClick={handleCopy}>
+          <Button onClick={handleCopy} title="Copy to clipboard">
             <ButtonIcon type="copy" />
           </Button>
         </div>

diff --git a/src/devtools/views/Components/InspectedElementTree.js b/src/devtools/views/Components/InspectedElementTree.js
@@ -38,7 +38,7 @@ export default function InspectedElementTree({
         <div className={styles.HeaderRow}>
           <div className={styles.Header}>{label}</div>
           {!isEmpty && (
-            <Button onClick={handleCopy}>
+            <Button onClick={handleCopy} title="Copy to clipboard">
               <ButtonIcon type="copy" />
             </Button>
           )}

diff --git a/src/devtools/views/Profiler/SnapshotSelector.js b/src/devtools/views/Profiler/SnapshotSelector.js
@@ -123,6 +123,7 @@ export default function SnapshotSelector(_: Props) {
         className={styles.Button}
         disabled={selectedFilteredCommitIndex === 0 || numFilteredCommits === 0}
         onClick={viewPrevCommit}
+        title="Select previous commit"
       >
         <ButtonIcon type="previous" />
       </Button>
@@ -159,6 +160,7 @@ export default function SnapshotSelector(_: Props) {
           selectedFilteredCommitIndex >= numFilteredCommits - 1
         }
         onClick={viewNextCommit}
+        title="Select next commit"
       >
         <ButtonIcon type="next" />
       </Button>