FEATURE: Dynamic presets #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add function withDataSourceAndTarget
feat: Add function createWithDataSourceAndTarget
Replaced createWithDataSourceAndTarget with createFromPreset. This allows a far easier way of dynamically changing Nodepaths in ContentRepositoryTarget. Thus import the same Preset under different paths depending on the imported objects context.
Add a variant to fromConfiguration(). Which allows to use an existing datasource with a given Configuration. Background: The idea here is to enable dynamically overriding the Datasource after loading the inital datasource config.
bwaidelich
changed the title
|
Thanks a lot for your contribution. I just tweaked the PR (i.e. commit) message slightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a variant to fromConfiguration() and additionally created createFromPreset()
Background: The idea here is to enable dynamically overriding the Datasource and Nodepaths in ContentRepositoryTarget after loading the inital datasource config. Thus import the same Preset under different paths depending on the imported objects context and/or using a different datasource.