Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "is null" and "is not null" to IteratorSqlFormatter #26

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Add "is null" and "is not null" to IteratorSqlFormatter #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f96b9
feat: add is null and not null to iteratorSqlFormatter
laisevn Dec 31, 2024
072b0f4
feat: add tests for relation is null and is not null
laisevn Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/IteratorFilterSqlFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ public function getRelation(string $name, Relation $relation, mixed $value, arra
}
return " $name NOT IN ($placeholders) ";
},
Relation::IS_NULL => function (&$param, $name, $paramName, $value) {
return " $name IS NULL ";
},
Relation::IS_NOT_NULL => function (&$param, $name, $paramName, $value) {
return " $name IS NOT NULL ";
},
};

return $data($param, $name, $paramName, $value); }
Expand Down
34 changes: 34 additions & 0 deletions tests/IteratorFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,40 @@ public function testAddRelationOr()
$this->assertEquals('select * from tablename where field = :field or field2 = :field2 ', $sql);
}

public function testRelationIsNull()
{
$this->object->and('field', Relation::IS_NULL, null);

$params = [];
$returnFields = '*';
$sql = $this->object->format(
new IteratorFilterSqlFormatter(),
'tablename',
$params,
$returnFields
);

$this->assertEquals([], $params);
$this->assertEquals('select * from tablename where field IS NULL ', $sql);
}

public function testRelationIsNotNull()
{
$this->object->and('field', Relation::IS_NOT_NULL, null);

$params = [];
$returnFields = '*';
$sql = $this->object->format(
new IteratorFilterSqlFormatter(),
'tablename',
$params,
$returnFields
);

$this->assertEquals([], $params);
$this->assertEquals('select * from tablename where field IS NOT NULL ', $sql);
}

public function testGroup()
{
$this->object->startGroup();
Expand Down
Loading