Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: strpos(): Non-string needles will be interpreted as strings in the future. #3

Open
burzum opened this issue Sep 12, 2019 · 6 comments

Comments

@burzum
Copy link

burzum commented Sep 12, 2019

I'm running php 7.3.9 and getting this:

Deprecated: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in C:\xampp\htdocs\wa-next-app\vendor\symfony\console\Command\Command.php on line 611

Call Stack:
    0.0002     417984   1. {main}() C:\xampp\htdocs\wa-next-app\vendor\byjg\migration-cli\scripts\migrate:0
    2.9629    1971912   2. ByJG\DbMigration\Console\InstallCommand->__construct() C:\xampp\htdocs\wa-next-app\vendor\byjg\migration-cli\scripts\migrate:21
    2.9629    1972072   3. ByJG\DbMigration\Console\InstallCommand->configure() C:\xampp\htdocs\wa-next-app\vendor\symfony\console\Command\Command.php:77
    2.9629    1972072   4. ByJG\DbMigration\Console\InstallCommand->configure() C:\xampp\htdocs\wa-next-app\vendor\byjg\migration-cli\src\InstallCommand.php:14
    3.3742    1975352   5. ByJG\DbMigration\Console\InstallCommand->addUsage() C:\xampp\htdocs\wa-next-app\vendor\byjg\migration-cli\src\ConsoleCommand.php:51
    3.3742    1975352   6. strpos() C:\xampp\htdocs\wa-next-app\vendor\symfony\console\Command\Command.php:611

I know it's the Symfony console dependency and not your repo, so my question is can you update the dependency to a version that might have fixed this?

Edit: I actually figured out it is already using v4.3.4 which seems to be the latest version.

byjg added a commit that referenced this issue Sep 12, 2019
This branch tries do fix issue #3
@byjg
Copy link
Owner

byjg commented Sep 12, 2019

Thank you for let us know about this issue. A new version 4.0.2 was created with the fix, however the Symfony package (v4.3.4) still with the deprecation warning :( . As we selected the package version in the composer ^4.3 I expected our project will be automatically fixed as soon the Symfony team fix that.

References: https://travis-ci.org/byjg/migration-cli/jobs/584193582

@burzum
Copy link
Author

burzum commented Sep 12, 2019

Thanks for the quick reply. Yes looks like we'll have to wait or use our own implementation. The Symfony console pulls in a lot dependencies we would like to avoid as we try to have as less dependencies as possible.

@byjg
Copy link
Owner

byjg commented Sep 13, 2019

To be honest, I don't like of the bunch of dependencies as well. If you have some alternative of the console, please let me know. I would love to replace it :)

byjg added a commit that referenced this issue Sep 17, 2019
@byjg byjg mentioned this issue Sep 17, 2019
Merged
@byjg
Copy link
Owner

byjg commented Sep 17, 2019

I fixed the deprecation issue by changing the code. You can download the release 4.0.3.

@burzum
Copy link
Author

burzum commented Nov 6, 2019

@byjg check https://github.com/thephpleague/climate/ if you're also looking for something with less dependencies. It won't pull half of the Symfony framework in.

@byjg
Copy link
Owner

byjg commented Nov 6, 2019

Excellent tip!! Maybe this can help me:
https://climate.thephpleague.com/arguments/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants