Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the codebase's type safety, improve dependency management, and add static analysis capabilities. The most significant changes include adding Psalm for static analysis, updating dependencies, and refining type hints across various database classes.
Static Analysis and Dependency Management:
.github/workflows/phpunit.yml
to include Psalm (./vendor/bin/psalm
).psalm.xml
..idea/runConfigurations/Psalm.xml
.composer.json
to includevimeo/psalm
as a development dependency and added autoload-dev section.Type Hinting and Code Refinement:
Enhanced type hinting and method signatures:
src/Database/AbstractDatabase.php
, including changing method signatures to specify return types and parameter types. [1] [2] [3]src/Database/DatabaseInterface.php
to include type hints for method parameters and return types.Consistent exception handling and import statements:
DblibDatabase
,MySqlDatabase
,PgsqlDatabase
,SqliteDatabase
). [1] [2] [3] [4]Breaking changes
MigrationStatus
, instead of constMigration::VERSION_*