Merge pull request #18 from PBXg33k/feature/php-8.4

Support for PHP 8.4
byjg · Nov 30, 2024 · fc3e8d3 · fc3e8d3
2 parents 75a5d09 + c02d9f4
commit fc3e8d3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         php-version:
+          - "8.4"
           - "8.3"
           - "8.2"
           - "8.1"

diff --git a/composer.json b/composer.json
@@ -10,12 +10,12 @@
   "prefer-stable": true,
   "minimum-stability": "dev",
   "require": {
-    "php": ">=8.1 <8.4",
+    "php": ">=8.1 <8.5",
     "psr/http-message": "^1.0|^1.1|^2.0"
   },
   "require-dev": {
     "phpunit/phpunit": "^9.6",
-    "vimeo/psalm": "^5.0"
+    "vimeo/psalm": "^6.0"
   },
   "autoload-dev": {
     "psr-4": {

diff --git a/src/Uri.php b/src/Uri.php
@@ -31,7 +31,7 @@ public function getScheme(): string
     private ?string $username = null;
     private ?string $password = null;
 
-    public function withUserInfo(string $user, string $password = null): UriInterface
+    public function withUserInfo(string $user, ?string $password = null): UriInterface
     {
         $clone = clone $this;
         $clone->username = $user;
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,7 @@ jobs: @@
         strategy:
           matrix:
             php-version:
+              - "8.4"
               - "8.3"
               - "8.2"
               - "8.1"
@@ Expand Down @@