Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPT tests can load helper scripts using special comments at the top. These scripts need to be loaded as though using a
<script>
tag, which doesn't create a new lexical scope, and hence causeslet
andconst
bindings to be visible in the global scope.Previously, to simulate this behavior using
eval
, the WPT harness replacedlet
andconst
withvar
. While this worked surprisingly well, it doesn't always work.This commit instead introduces an
evalScript
function available to the harness, which evaluates in a way more closely matching that of script tags.