Enhance LLVM AOT/JIT stack frame dump #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a dedicate document to describe the current implementation and motivation? |
Yes, I will open a new issue to describe them later. |
Merge bytecodealliance:dev/aot_stack_frame into wenyongh:dev/aot_stack_frame
no1wudi
reviewed
Aug 25, 2023
| /* The non-imported function index of current function */ | ||
| uintptr_t func_index; | ||
|
|
||
| /* Used when performance profiling is enabled */ |
There was a problem hiding this comment.
Should we guard time_started with WASM_ENABLE_PERF_PROFILING ?
There was a problem hiding this comment.
Had better not, the field offsets of AOTFrame had better be fixed so the AOT compiler doesn't need to calculate them (e.g. ip_offset/sp/frame_ref/lp) according to the target architectures in running, like some fields in AOTModuleInstance, WASMMemoryInstance and WASMExecEnv.
Note that I added some bh_static_assert sentences in aot_runtime.c.
no1wudi
approved these changes
Aug 25, 2023
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Aug 28, 2023
Enhance LLVM AOT/JIT stack frame dump (bytecodealliance#2350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a full LLVM AOT/JIT stack frame dump:
commit the function arguments, locals, stack operands from LLVM values to the stack frame,
which is required for the GC AOT/JIT feature, and may be required by the aot debug, aot snapshot
and other features.
Refer to:
#2144
#2333