Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasm-encoder to 0.34.0 and wasmparser to 0.114.0 #1247

Merged

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Oct 12, 2023

No description provided.

@fitzgen fitzgen requested a review from alexcrichton October 12, 2023 15:14
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen force-pushed the bump-wasmparser-and-wasm-encoder branch from a8749ff to 2e136a7 Compare October 12, 2023 15:19
@fitzgen fitzgen enabled auto-merge (squash) October 12, 2023 15:20
@fitzgen fitzgen merged commit 0503ba5 into bytecodealliance:main Oct 12, 2023
@fitzgen fitzgen deleted the bump-wasmparser-and-wasm-encoder branch October 12, 2023 15:37
@tamird
Copy link

tamird commented Oct 12, 2023

I think this is the cause of bytecodealliance/wit-bindgen#697 - two crates got minor version bumps, but all the other crates got patch bumps.

Then today wit-component got a patch release, but bumped its dependency on wit-parser by a minor version. That means that any dependent that uses both (even indirectly) is hosed until the rest of the ecosystem cuts new releases.

Another way to avoid this would be to not expose foreign types in the APIs, but that ship has likely sailed.

@alexcrichton
Copy link
Member

Yes thanks for the heads up, and this is my mistake as I didn't catch this. I posted #1250 to fixup the versions and additionally future-proof this (hopefully). I'll yank the broken versions once those are published to avoid future breakage.

@tamird
Copy link

tamird commented Oct 14, 2023

Thanks.

I'll yank the broken versions once those are published to avoid future breakage.

Has this happened?

@alexcrichton
Copy link
Member

I've just now done the yanks, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants