Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Func::wrap support for functions using reference types #1868

Closed
fitzgen opened this issue Jun 11, 2020 · 1 comment
Closed

Enable Func::wrap support for functions using reference types #1868

fitzgen opened this issue Jun 11, 2020 · 1 comment
Labels
wasmtime Issues about wasmtime that don't fall into another label

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 11, 2020

Func::wrap doesn't currently work for functions using externref. We should plumb support through.
@fitzgen fitzgen added the wasmtime Issues about wasmtime that don't fall into another label label Jun 11, 2020
@fitzgen fitzgen mentioned this issue Jun 11, 2020
Closed
29 tasks
fitzgen added a commit to fitzgen/wasmtime that referenced this issue Jun 12, 2020
@fitzgen
wasmtime: Add Func::wrap support for functions using reference types
bc6c5e4 
Fixes bytecodealliance#1868
@fitzgen
Copy link
Member Author

fitzgen commented Jun 16, 2020

This is a little tricky because it requires that the shim function inside the IntoFunc impl macro is directly callable from Wasm, but we need to re-wrap the VMExternRef that Wasm is actually working with into an ExternRef that also has a weak handle to the store.

@fitzgen fitzgen closed this as completed in 46ef80b Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wasmtime Issues about wasmtime that don't fall into another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen