-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmtime: support reference types on aarch64 #1886
Comments
For tracking purposes: the initial support for the ref values and opcodes themselves on AArch64 is in the WIP PR #1852, and @julian-seward1 and I are working out the safepoints story from the regalloc.rs and isel sides respectively. We should have at least an initial version done in the next few weeks. We're pushing things forward for the SpiderMonkey use-case and planning to test there, so I'll be interested to see how we interface with |
Thanks for the update @cfallin! FYI we now have
The stack maps interfaces definitely need a little finessing (one example off the top of my head would be to have "semantic" methods rather than just exposing the inner bit map directly and expecting callers to figure out how to interpret that; also I suspect we can do better than iterating over every word in the frame and have an iterator over only the live refs instead). As long as everything remains SP-relative, then I think Wasmtime should be fine (getting SP portably and reliably is much easier than getting the CFA with libunwind). |
With bytecodealliance#1852, we now have support for reference types in the new backend framework generally, and on aarch64 in particular. This PR removes the test-ignore directive for reftypes tests on this platform. Closes bytecodealliance#1886.
With bytecodealliance#1852, we now have support for reference types in the new backend framework generally, and on aarch64 in particular. This PR removes the test-ignore directive for reftypes tests on this platform. Closes bytecodealliance#1886.
Fixed by #2410. |
I think this should mostly Just Work after #1617 lands, but we also need to remove these
cfg
s (and make sure the tests pass, ofc):wasmtime/build.rs
Lines 214 to 216 in 647d2b4
wasmtime/tests/all/main.rs
Lines 22 to 24 in 647d2b4
The text was updated successfully, but these errors were encountered: