Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make define_unknown_imports_as_traps available in CLI #9019

Closed
StaticallyTypedAnxiety opened this issue Jul 26, 2024 · 0 comments · Fixed by #9021
Closed

Make define_unknown_imports_as_traps available in CLI #9019

StaticallyTypedAnxiety opened this issue Jul 26, 2024 · 0 comments · Fixed by #9021

Comments

@StaticallyTypedAnxiety
Copy link

Thanks for filing a feature request! Please fill out the TODOs below.

Feature

Add define_unknown_imports_as_traps in the wasmtime CLI as it is available in the component Linker https://docs.rs/wasmtime/latest/wasmtime/component/struct.Linker.html#method.define_unknown_imports_as_traps

Benefit

Can be used to specify behavior when setting up WASI test runners

Implementation

Add Component Method here: https://github.com/bytecodealliance/wasmtime/blob/main/src/commands/run.rs#L386
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Jul 26, 2024
@alexcrichton
Add support for -Wunknown-imports-trap to components
51b5dd8 
This was implemented in bytecodealliance#8672 and is an easy addition to the CLI.

Closes bytecodealliance#9019
@alexcrichton alexcrichton mentioned this issue Jul 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 26, 2024
@alexcrichton
Add support for -Wunknown-imports-trap to components (#9021)
57049dd 
* Add support for `-Wunknown-imports-trap` to components

This was implemented in #8672 and is an easy addition to the CLI.

Closes #9019

* Fix non-component CLI build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for -Wunknown-imports-trap to components alexcrichton/wasmtime
1 participant
@StaticallyTypedAnxiety