cranelift: Add MinGW fma regression tests
#4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
|
Since this is just for the interpreter one possibility would be to use |
alexcrichton
approved these changes
Jul 25, 2022
|
libm's I've filed rust-lang/libm#263 to follow up with libm. |
|
@alexcrichton since there is no way to know how long this is going to take with libm. What do you think about disabling the interpreter on the An alternative could be to have a reduced set of inputs that does not fail in a separate file. That way we can resolve this now and move ahead with the CI upgrades. |
The interpreter can run `fma.clif` on most platforms, however on `x86_64-pc-windows-gnu` we use libm which has issues with some inputs. We should delete `fma-interpreter.clif` and enable the interpreter on the main `fma.clif` file once those are fixed.
afonso360
force-pushed
the
mingw-fma-regress
branch
from
1ff2113 to
f157967
Compare
|
Sounds reasonable to me, thanks for helping to push on this @afonso360! |
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Aug 10, 2022
This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs. See: bytecodealliance#4517
alexcrichton
pushed a commit
that referenced
this pull request
Aug 10, 2022
* cranelift: Upgrade libm to 0.2.4 This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs. See: #4517 * supply-chain: Vet `libm` 0.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4512 for context.
It looks like MinGW has an incorrect implementation of
fma. This did not show up in the currentfmatest suite, but it did show when @alexcrichton tried to upgrade towindows-lateston CI.In this PR we just add the test cases that were submitted to the original bug report of MinGW.
Opening this as a draft, and eventually we'll add a fix for this as well.
cc: @cfallin @alexcrichton