riscv64: Fix regalloc panic with bor+bnot on floats
#5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonso360
changed the title
bor+bnot on floatsbor+bnot on floats
github-actions
bot
added
the
cranelift
elliottt
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
With
zbbenabled we were optimizingbor+bnotinto theorninstruction. We were accidentally also enabling this operation for floats without first moving the float to an integer register. This caused a regalloc error since we can't use those instructions directly on floats.I've also tried to restrict the matches for some other rules that could probably suffer the same issue. Though the fuzzer hasn't complained about those yet.