wasi-http: Migrate to more descriptive error variant #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/wasi-http-errors
branch
from
84c6b44 to
89f1876
Compare
elliottt
commented
Nov 2, 2023
Comment on lines
-119
to
-128
| // TODO: maybe anything that appears in the Result<_, E> position should impl | ||
| // Error? anyway, just use its Debug here: | ||
| .map_err(|e| anyhow!("{e:?}"))?; |
There was a problem hiding this comment.
This was preventing downcast::<Error>() in test cases.
elliottt
force-pushed
the
trevor/wasi-http-errors
branch
7 times, most recently
from
f113348 to
f088227
Compare
elliottt
force-pushed
the
trevor/wasi-http-errors
branch
from
61bd17b to
aebbe78
Compare
elliottt
force-pushed
the
trevor/wasi-http-errors
branch
from
aebbe78 to
7af92d0
Compare
|
@pchickey this should be ready to go now. I also folded in the changes to URI construction in the outgoing handler that we discussed today. |
pchickey
approved these changes
Nov 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
elliottt
force-pushed
the
trevor/wasi-http-errors
branch
from
2724b1f to
c1b0290
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
prtest:full
elliottt
force-pushed
the
trevor/wasi-http-errors
branch
from
69708fe to
ebabc9f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 11, 2023
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 12, 2023
…e#7434) * Migrate to a more specific error-code variant in wasi-http Co-authored-by: Pat Hickey <[email protected]> * Optional fields, and align with upstream pr * Update for upstream changes to the error-code variant * Sync with the upstream implementation * Missed updating an error for riscv64 and s390x * More debuggable error prtest:full * Try to stabilize the test on windows --------- Co-authored-by: Pat Hickey <[email protected]>
alexcrichton
added a commit
that referenced
this pull request
Nov 13, 2023
* Remove timezone interface from wasi-clocks (#7515) * delete wasi-clocks timezone interface: import wit changes from WebAssembly/wasi-clocks#55 * remove other references to wasi:clocks/timezone in wits * remove todo! implementation of clocks/timezone and add_to_linker funcs * Move the `wasi:io/stream/error` resource into `wasi:io/error` (#7521) * Move the `error` resource into `wasi:io/error` * error.wit: update doc comments * downstream fixes to streams.wit doc comments * fix package name in error.wit --------- Co-authored-by: Trevor Elliott <[email protected]> * wasi-http: Make child fields immutable (#7524) * Make child fields immutable * Add `get_fields` and remove `FieldMapMutability` Clean up the interface to immutable fields by adding a different accessor. * Clean up the diff * wasi-http: Migrate to more descriptive error variant (#7434) * Migrate to a more specific error-code variant in wasi-http Co-authored-by: Pat Hickey <[email protected]> * Optional fields, and align with upstream pr * Update for upstream changes to the error-code variant * Sync with the upstream implementation * Missed updating an error for riscv64 and s390x * More debuggable error prtest:full * Try to stabilize the test on windows --------- Co-authored-by: Pat Hickey <[email protected]> * Remove a debugging eprintln (#7528) * Remove no-longer-necessary reactor world (#7516) The `wasi:cli` WIT package now has a `reactor` world so the adapter can use that instead of defining its own. --------- Co-authored-by: Pat Hickey <[email protected]> Co-authored-by: Trevor Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the more descriptive error variant present in WebAssembly/wasi-http#52. This PR attempts to port the existing errors we raise directly to the new variant.
Fixes #7248