Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating interface names which are Rust keywords #7790

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix generating interface names which are Rust keywords #7790

merged 1 commit into from
Feb 12, 2024

Conversation

Archisman-Mridha
Copy link
Contributor

Fixes #7784

@Archisman-Mridha Archisman-Mridha requested a review from a team as a code owner January 18, 2024 04:39
@Archisman-Mridha Archisman-Mridha requested review from pchickey and removed request for a team January 18, 2024 04:39
@Archisman-Mridha Archisman-Mridha changed the title Fix for #7784 Fix generating interface names which are Rust keywords Jan 18, 2024
@alexcrichton
Copy link
Member

Thanks! With the test failure on CI I think there may be a few more cases that need to be handled?

@Archisman-Mridha
Copy link
Contributor Author

Archisman-Mridha commented Feb 12, 2024 •
edited
Loading

Hey, sorry for stretching this. I had to deal with my exams :).

My earlier commit wasn't the actual solution to the problem.

I have pushed another commit containing the actual fix. Please approve the CI when you get time.

alexcrichton
alexcrichton approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, and thanks again!

@alexcrichton alexcrichton added this pull request to the merge queue Feb 12, 2024
Merged via the queue into bytecodealliance:main with commit e9a2318 Feb 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@pchickey pchickey Awaiting requested review from pchickey pchickey is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bindgen: Generates names which may have Rust keywords
2 participants
@Archisman-Mridha @alexcrichton