Use AlmaLinux:8 for x86_64-linux binary-compatible-builds #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/bcb-ubuntu
branch
from
bcf1b62 to
87a904d
Compare
elliottt
changed the title
elliottt
requested review from
fitzgen and
jameysharp
and removed request for
a team
jameysharp
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
This makes sense to me.
I think it's worth specifically calling out that AlmaLinux 8 is the current recommended base for Python's manylinux, which exists to solve essentially the same problem.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fitzgen
added a commit
to fitzgen/wizer
that referenced
this pull request
Aug 19, 2024
The `centos:7` image hit end of life, so we need something new. Similar to bytecodealliance/wasmtime#8892 in Wasmtime.
fitzgen
added a commit
to bytecodealliance/wizer
that referenced
this pull request
Aug 19, 2024
…ds (#108) * Update the binary-compatible-builds action from Wasmtime * Use `almalinux:8` as base image for x86_64-linux CI docker image The `centos:7` image hit end of life, so we need something new. Similar to bytecodealliance/wasmtime#8892 in Wasmtime. * Allos `cfg(fuzzing)` * Remove dead code ever since module-linking support was removed * set global npm config with sudo in ci
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7 has hit EOL, and is beginning to cause build failures due to mirror lists being unavailable. This PR switches us over to using AlmaLinux 8 instead.
AlmaLinux 8 has cmake-3.26, so it's reasonable to continue explicitly installing cmake-3.29.