wasi-common
: remove wasmtime
dependency from sync
crate feature
#8900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8894.
Motivation: This allows usage of
wasi-common
in non-Wasmtime Wasm runtimes.This was probably an oversight in #7881.
The only optional usage of the
wasmtime
crate that I could find within thewasi-common/sync
module is the following:Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs
Which defines the
add_to_linker
methods for Wasmtime which is entirely optional.Non Wasmtime users of
wasi-common
might want to define their ownadd_to_linker
functions.Locally I did not see any compile errors with the removal of this dependency of this PR.