-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support for the mxnet preset (issue #234) #236
Conversation
Could you make it so that it builds from source? |
It is possible, but on a normal windows system you don't have OpenBLAS installed and added to your PATH. Which means we would need to include it (plus its dependencies libgcc_s_seh-1.dll, libgfortran-3.dll, libquadmath-0.dll) to the resulting .jar file. Increasing the size by about 40MB. For windows it would be good to use the existing/installed libraries and warn the user it they are not configured correctly. |
OpenBLAS comes with MSYS2. Just call
|
And if we add them to the |
But it shouldn't increase the size by more than 10 megs though. Where do you get 40 megs from? |
I have installed the OpenBLAS binary and the libopenblas.dll inside is 38MB. Getting OpenBLAS via MSYS2 downloads a 33MB libopenblas.dll. If we bundle all the necessary binaries together it will result in a >40MB MXNet jar file. We will need OpenBLAS for other libraries as well, so I was thinking that there might be another way to distribute the 3rd party libraries. |
Right, but compressed it's more like 5 megs: |
Sure, we could make presets for OpenBLAS. After all, it gets used by Caffe, GSL, ND4J, and probably others as well. BLAS is an API implemented by other libraries though, so we might want to figure out how to make binaries compatible with MKL as well: #112 |
Build instructions for Windows are available here: |
The next 2-3 weeks are full or work, but I think within the next month it should be ready. |
Duplicate of #309. Please don't create duplicate pull requests. Simply update the pull request next time!! Thank you |
No description provided.