Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26 LN_KIB / LN_KB are backwards #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChanTsune
Copy link
Contributor

Hi @hyunsik

I found that part of #33 can solve #26, so I made this PR.

This change causes no problems for the most part, but I am making changes to the existing test cases just because they are affected by #26.

This change will also help #3

@hyunsik
Copy link
Collaborator

hyunsik commented Sep 6, 2023

I'm sorry for a late review. I'll review asap by this week.

@Andrew15-5
Copy link

@ChanTsune, the problem is that not only LN_KIB & LN_KB have each other's values, but SI conditions are also inverted. I made a PR (#38) which fixes the whole "inverted thing" and now if SI condition is true it will show SI unit instead of IEC. It probably would be the best if #38 is merged first and then, with small tweaks (but the main logic change intact), #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants