feat: merge foyer-rs/bytesize back to the OG repo #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
* chore: release foyer-bytesize v2.0.0 Signed-off-by: MrCroxx <[email protected]> * chore: fix doc test Signed-off-by: MrCroxx <[email protected]> * chore: add doc test on CI Signed-off-by: MrCroxx <[email protected]> --------- Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
robjtede
requested changes
Oct 11, 2024
CHANGELOG
Outdated
CHANGELOG
Outdated
Comment on lines
3
to
10
| ## (reserved for the release date) | ||
|
|
||
| Release version v2.0.0 | ||
|
|
||
| Changes: | ||
|
|
||
| - Use SI format by default with `Display`. | ||
| - Use "KiB" for SI unit. |
There was a problem hiding this comment.
Suggested change
| ## (reserved for the release date) | |
| Release version v2.0.0 | |
| Changes: | |
| - Use SI format by default with `Display`. | |
| - Use "KiB" for SI unit. | |
| ## Unreleased | |
| - Use SI format by default with `Display`. | |
| - Use "KiB" for SI unit. |
Cargo.toml
Outdated
| description = "an utility for human-readable bytes representations" | ||
| version = "1.4.0-dev" | ||
| authors = ["Hyunsik Choi <[email protected]>"] | ||
| description = "An utility for human-readable bytes representations. Forked from https://github.com/hyunsik/bytesize ." |
There was a problem hiding this comment.
Suggested change
| description = "An utility for human-readable bytes representations. Forked from https://github.com/hyunsik/bytesize ." | |
| description = "A utility for human-readable bytes representations" |
README.md
Outdated
| @@ -1,12 +1,14 @@ | |||
| ## ByteSize | |||
| [](https://travis-ci.org/hyunsik/bytesize) | |||
|
|
|||
| [](https://github.com/hyunsik/bytesize/actions/workflows/rust.yml) | |||
There was a problem hiding this comment.
Suggested change
| [](https://github.com/hyunsik/bytesize/actions/workflows/rust.yml) | |
| [](https://github.com/hyunsik/bytesize/actions/workflows/rust.yml) |
.github/workflows/rust.yml
Outdated
There was a problem hiding this comment.
i have suggestions about CI but will submit them in an MR later
Cargo.toml
Outdated
| version = "1.4.0-dev" | ||
| authors = ["Hyunsik Choi <[email protected]>"] | ||
| description = "An utility for human-readable bytes representations. Forked from https://github.com/hyunsik/bytesize ." | ||
| version = "2.0.0" |
There was a problem hiding this comment.
lets hold off on a version bump for right now
Suggested change
| version = "2.0.0" | |
| version = "1.4.0-dev" |
Signed-off-by: MrCroxx <[email protected]>
|
@robjtede Suggestion applied. PTAL 🙏 |
Signed-off-by: MrCroxx <[email protected]>
robjtede
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Related issues & PRs
#49