Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module info #136

Merged
merged 5 commits into from
May 24, 2023
Merged

Module info #136

merged 5 commits into from
May 24, 2023

Conversation

c-eg
Copy link
Owner

@c-eg c-eg commented May 19, 2023 •
edited
Loading

fixes #135

Changes:

  • Updated gradle to 8.1.1
  • Updated dependencies to latest versions (except Jackson, see here as to why)
  • Added module-info.java
  • Removed unnecessary HttpClientProxy.java - was not used and was breaking module-info
  • Fixed tests not compiling on Windows due to a UTF-8 issue

@holgerbrandl holgerbrandl merged commit 44fea2e into c-eg:master May 24, 2023
@holgerbrandl
Copy link
Collaborator

Great moderniziation!

@holgerbrandl
Copy link
Collaborator

I have published the new build as v0.14 to maven-central

@c-eg c-eg deleted the module_info branch May 24, 2023 16:08
@c-eg
Copy link
Owner Author

c-eg commented May 24, 2023

Brilliant thank you!

@c-eg
Copy link
Owner Author

c-eg commented May 24, 2023

@holgerbrandl after checking on maven central, it doesn't appear to be published yet?
https://central.sonatype.com/artifact/com.github.holgerbrandl/themoviedbapi/1.12

@holgerbrandl
Copy link
Collaborator

Indeed my bad. The build failed silently and I did not notice. After some minor javadoc fixes, I could publish it. For now, pls see https://repo1.maven.org/maven2/com/github/holgerbrandl/themoviedbapi/ ( because the maven search lags behind by some minutes/hours).

Thanks for the pointer!

@c-eg
Copy link
Owner Author

c-eg commented May 25, 2023

Ah okay, thanks for fixing it. It's now on maven central :)

@c-eg c-eg mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No module-info
2 participants
@c-eg @holgerbrandl